Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/1149#discussion_r39947900
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,486 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/1149#discussion_r39948297
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSP.java
---
@@ -110,24 +105,20 @@ public static void
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1149#discussion_r39948730
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSP.java
---
@@ -110,24 +105,20 @@ public static void main(String
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1149#issuecomment-141905104
Hi @vasia,
As you said, I already reviewed this :P. I left a couple of comments
inline. Please reverify the forwarded fields annotations. If you put them
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1149#discussion_r39948692
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,486 @@
+/*
+ * Licensed to the Apache
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1149#issuecomment-141905875
Thanks @andralungu! I'll address your comments and merge later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1149
[FLINK-1520] [gelly] Create a Graph from CSV files
This builds on @shghatge's work in #847.
I addressed the remaining issues, rebased, and edited the docs.
@andralungu, you've already reviewed
