[GitHub] flink pull request: [FLINK-1521] Chained operators respect reuse

2015-02-19 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/392#issuecomment-75029399 Alright, I`m closing this PR then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-1521] Chained operators respect reuse

2015-02-19 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1521] Chained operators respect reuse

2015-02-17 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/392#issuecomment-74650731 +1 I opened FLINK-1565 for documenting object reuse behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-1521] Chained operators respect reuse

2015-02-16 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/392#issuecomment-74565272 At this point, we also have to worry about efficiency and performance. This is also something that the user can easily mitigate in the UDF, at a fraction of the cos

[GitHub] flink pull request: [FLINK-1521] Chained operators respect reuse

2015-02-14 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/392#issuecomment-74367347 The problem here I think that an error caused by the reusing mapper could be very hard to detect. So some users might have it but they don't realise. For streaming

[GitHub] flink pull request: [FLINK-1521] Chained operators respect reuse

2015-02-13 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/392#issuecomment-74237302 I agree with Stephan to not copy records for chained mappers. However, we should clearly document the behavior of the different modes or at least the behavior of the de

[GitHub] flink pull request: [FLINK-1521] Chained operators respect reuse

2015-02-13 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/392#issuecomment-74234126 While this change makes it technically more correct, I think it will have a massive negative impact on performance. Nobody can be expected to turn on the object reuse

[GitHub] flink pull request: [FLINK-1521] Chained operators respect reuse

2015-02-12 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/392 [FLINK-1521] Chained operators respect reuse You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/incubator-flink flink-1521 Alternatively you