Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/394#issuecomment-74388302
No worries, thanks for replying to my concern =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/394#issuecomment-74385078
@hsaputra, sorry I did not see your comments before I committed the PR. I
started merging it yesterday but it always failed because of some minor issues
on Travis. Th
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/394#discussion_r24716021
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -486,7 +489,8 @@ protected void run() {
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/394#issuecomment-74384108
@tillrohrmann I had concern about style and question about value about
parameter passed.
Would be nice to address those before committing.
---
If your project is set
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/394#discussion_r24693247
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -486,7 +489,8 @@ protected void run() {
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/394#discussion_r24690375
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -486,7 +489,8 @@ protected void run() {
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/394#discussion_r24689680
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -517,67 +521,83 @@ protected int list(String[] args) {
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/394#discussion_r24689710
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -517,67 +521,83 @@ protected int list(String[] args) {
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/394#issuecomment-74311404
+1 Nice work and a critical fix. Prevents the root actors from failing on
user code problems.
---
If your project is set up for it, you can reply to this email and ha
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/394
[FLINK-1543] Adds better exception handling in actors
Adds try and catch blocks around exception throwing methods in the
JobManager and TaskManager. This PR is based on #384.
You can merge this
11 matches
Mail list logo
