Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-78889015
Hey Henry,
I'm sorry that the change is making your builds so much slower. My linux
machine needs 5 minutes to build the current master.
I suspect there is somethi
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-78560058
How much time does this new shading add to the total compile? It used to be
around 16-18mins for me using mvn clean install -DskipTests.
I just did merge today an
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26199718
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/FlinkYarnClient.java ---
@@ -238,6 +239,15 @@ public int getTaskManagerCount() {
@O
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-78235211
Thanks for the review.
I'll address your comments and then merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-78234801
That are some massive changes to the pom files. As far as I can tell it
looks good to me. The ```Akka``` changes look good.
---
If your project is set up for it, you
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26199913
--- Diff: pom.xml ---
@@ -1159,6 +726,55 @@ under the License.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26199162
--- Diff: flink-shaded-hadoop/pom.xml ---
@@ -60,19 +73,36 @@ under the License.
false
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26199016
--- Diff: flink-shaded-hadoop/flink-shaded-include-yarn-tests/pom.xml ---
@@ -0,0 +1,78 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi=
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-78047798
Looks good to me.
+1 to merge, if Travis (or Bob the Builder) agrees
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-78047279
Thank you for reviewing the change.
* The exclusions for the `flink-clients` were indeed wrong. Good catch!
* It doesn't make much sense to set a main class fo
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-78022132
Here are some points to double check
- You exclude all the `flink-clients` web docs from the uberjar. I would
guess this breaks the webclient, because it uses the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26108289
--- Diff: flink-shaded-hadoop/flink-shaded-include-yarn/pom.xml ---
@@ -0,0 +1,286 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26108269
--- Diff: flink-shaded-hadoop/flink-shaded-hadoop2/pom.xml ---
@@ -0,0 +1,183 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26108286
--- Diff: flink-shaded-hadoop/flink-shaded-include-yarn/pom.xml ---
@@ -0,0 +1,286 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26108259
--- Diff: flink-shaded-hadoop/flink-shaded-hadoop2/pom.xml ---
@@ -0,0 +1,183 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26108263
--- Diff: flink-shaded-hadoop/flink-shaded-hadoop2/pom.xml ---
@@ -0,0 +1,183 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26108294
--- Diff: flink-shaded-hadoop/flink-shaded-include-yarn/pom.xml ---
@@ -0,0 +1,286 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26108278
--- Diff: flink-shaded-hadoop/flink-shaded-include-yarn/pom.xml ---
@@ -0,0 +1,286 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26108281
--- Diff: flink-shaded-hadoop/flink-shaded-include-yarn/pom.xml ---
@@ -0,0 +1,286 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/454#discussion_r26108253
--- Diff: flink-shaded-hadoop/flink-shaded-hadoop1/pom.xml ---
@@ -0,0 +1,79 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-77921349
The pull request has been rebased to master.
I'm looking for some feedback for this change.
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-77344732
I know, the stuff is very complicated.
I've documented the setup here:
https://cwiki.apache.org/confluence/display/FLINK/Dependency+Shading+in+Flink
Please le
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-77237532
Looks good, but also like a lot of magic. Can you briefly summarize here
(and copy it to the wiki) how the setup works? I am especially confused by the
extra YARN shad
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/454
[FLINK-1605] Bundle all hadoop dependencies and shade guava away
I don't have a working eclipse setup right now, so I didn't test this
change with eclipse.
I would be very interested in som
25 matches
Mail list logo
