[GitHub] flink pull request: [FLINK-1635] remove Apache Thrift and Google P...

2015-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1635] remove Apache Thrift and Google P...

2015-06-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/794#issuecomment-109355770 +1 to merge like this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1635] remove Apache Thrift and Google P...

2015-06-05 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/794#issuecomment-109355690 I also added the necessary Maven configuration for the examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-1635] remove Apache Thrift and Google P...

2015-06-05 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/794#discussion_r31827450 --- Diff: docs/apis/best_practices.md --- @@ -155,3 +155,41 @@ public static final class Tokenizer extends RichFlatMapFunctionString, Tuple2S