Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/453
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/453#issuecomment-77254599
Thanks @uce and @hsaputra! I addressed your comments and rebased.
Will merge tomorrow if nobody raises a flag.
---
If your project is set up for it, you can reply to t
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/453#discussion_r25801300
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/Path.java ---
@@ -217,7 +211,17 @@ public Path(String pathString) {
*the path stri
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/453#issuecomment-77218259
:+1: Looks good to me. I've tried it out locally. Nice that you added tests
:)
My inline comments regarding the tests are very general and don't really
need be addre
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/453#discussion_r25796503
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/Path.java ---
@@ -217,7 +211,17 @@ public Path(String pathString) {
*the path string
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/453#discussion_r25795975
--- Diff: flink-core/src/test/java/org/apache/flink/core/fs/PathTest.java
---
@@ -23,6 +23,152 @@
import static org.junit.Assert.*;
public class Pa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/453#discussion_r25795767
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileOutputFormatTest.java
---
@@ -44,7 +44,7 @@ public void testCreateNoneParallelLocalFS() {
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/453
[FLINK-1640] Remove tailing slash from paths.
- Remove tailing slash from paths.
- Add tests for Path and FileOutputFormat.
Tailing slashes were previously not removed from paths which
