[GitHub] flink pull request: [FLINK-1664] Adds checks if selected sort key ...

2015-04-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1664] Adds checks if selected sort key ...

2015-04-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/541#discussion_r27721821 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/DataSink.java --- @@ -208,6 +214,28 @@ public DataSink(DataSet data, OutputFormat forma

[GitHub] flink pull request: [FLINK-1664] Adds checks if selected sort key ...

2015-04-02 Thread hsaputra
Github user hsaputra commented on a diff in the pull request: https://github.com/apache/flink/pull/541#discussion_r27715729 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/DataSink.java --- @@ -208,6 +214,28 @@ public DataSink(DataSet data, OutputFormat form

[GitHub] flink pull request: [FLINK-1664] Adds checks if selected sort key ...

2015-04-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/541#issuecomment-89010189 Will rebase and merge this in about 24h unless somebody raises a flag. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] flink pull request: [FLINK-1664] Adds checks if selected sort key ...

2015-03-27 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/541 [FLINK-1664] Adds checks if selected sort key is sortable - Adds checks if a sort key can be actually sorted. - The POJO type is defined as non-sortable, because an order would depend on the u