[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...

2015-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/627 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...

2015-05-04 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/627#issuecomment-98781884 Any objections against merging this PR? Otherwise, I'll do that tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...

2015-04-27 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/627#issuecomment-96631688 Yes, very good point. I replaced the `.print()` statements by `.output(new DiscardingOutputFormat()` as suggested (not only in the ported tests but also some more on t

[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...

2015-04-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/627#issuecomment-96580250 Wow, very nice :-) Looks correct from a first glance (I did not thoroughly check everything). One remark: Since `print()` may become an eagerly evaluated comma

[GitHub] flink pull request: [FLINK-1682] Ported optimizer unit tests from ...

2015-04-27 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/627 [FLINK-1682] Ported optimizer unit tests from Record API to Java API This is a step towards removing the deprecated Record API. You can merge this pull request into a Git repository by running: