Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/521#issuecomment-104919076
Started working on this: rebased after Aljoscha's change, and found some
minor issues - fixing those.
---
If your project is set up for it, you can reply to this email
Github user szape commented on the pull request:
https://github.com/apache/flink/pull/521#issuecomment-103842766
Thank you Robert. Unfortunately, I didn't have much time this week to
review the code. As soon as I'm done with the storm compatibility examples,
I will be able to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/521#discussion_r30683603
--- Diff:
flink-staging/flink-streaming/flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/SourceAPITest.scala
---
@@ -0,0 +1,22 @@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/521#discussion_r30683935
--- Diff:
flink-staging/flink-streaming/flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
---
@@
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/521#issuecomment-103822246
The change looks good in theory but there are some details that need some
reworking.
---
If your project is set up for it, you can reply to this email and have your
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/521#discussion_r30523005
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/521#issuecomment-95199623
Hey Peti,
I added a refactor commit that reworked the way types are handled in the
sources a little bit.
Github user szape commented on the pull request:
https://github.com/apache/flink/pull/521#issuecomment-85409807
Only new methods are added. There are two versions of generateSequence: a
new parallel one, as in the batch API, but the old, sequential one is also
useful for testing.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/521#issuecomment-85412269
Okay, cool.
Let us know when the pull request is ready for another round of reviews.
---
If your project is set up for it, you can reply to this email and have your
Github user szape commented on a diff in the pull request:
https://github.com/apache/flink/pull/521#discussion_r27010053
--- Diff:
flink-staging/flink-streaming/flink-streaming-examples/src/main/java/org/apache/flink/streaming/examples/ReadFileExample.java
---
@@ -0,0 +1,37 @@
Github user szape commented on the pull request:
https://github.com/apache/flink/pull/521#issuecomment-85406974
I completeness checking between the streaming and batch java API sounds to
be a great idea. I wouldn't force syncing in any other way, because there can
be source methods
GitHub user szape opened a pull request:
https://github.com/apache/flink/pull/521
[FLINK-1687] [streaming] Syncing streaming source API with batch source API
It is important to keep the streaming and the batch user facing API
synchronised in regard of the source and sink functions
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/521#issuecomment-85154634
Ah, it would also be good to rebase this PR to the current master to get
some feedback from travis
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/521#discussion_r26968237
--- Diff:
flink-staging/flink-streaming/flink-streaming-examples/src/main/java/org/apache/flink/streaming/examples/ReadFileExample.java
---
@@ -0,0 +1,37 @@
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/521#issuecomment-85154551
Would it make sense to add a API completeness checker between the streaming
and batch java API (similar to the java/scala API completeness checker?) The
whitelist is
15 matches
Mail list logo
