Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/547#issuecomment-91048962
Thanks so much for the review @fhueske, @StephanEwen!
I'll make the suggested changes and merge :-)
---
If your project is set up for it, you can reply to this email and
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/547#issuecomment-90883704
I like the change as well! Good to go!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/547#issuecomment-90863498
LGTM
I browsed the diffs and didn't find anything crucial. Just a typo and one
possible simplification.
The change makes vertex iterations much easier to use a
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/547#discussion_r27955651
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -1118,30 +1119,52 @@ public boolean filter(Edge edge) {
}
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/547#discussion_r27955499
--- Diff: docs/gelly_guide.md ---
@@ -343,29 +343,86 @@ Vertex-centric Iterations
Gelly wraps Flink's [Spargel API](spargel_guide.html) to provide methods
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/547#issuecomment-90745094
Hi,
any opinions on this?
I would like to merge it soon because it changes the api and vertex-centric
related issues depend on it.
Thanks!
---
If your project
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/547
[FLINK-1694] [gelly] added IterationConfiguration as a way to configure ...
...a VertexCentricIteration and avoid the split between create and run
methods.
You can merge this pull request into a Git r