GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/719
[FLINK-1874] [streaming] Connector breakup
Connectors separated into maven modules, named e.g. flink-kafka-connector.
Plus an additional commit to remove the flume connector from the docs f
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/719#issuecomment-104872808
Great, thank you for fixing this.
I'll soon review it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/719#issuecomment-105914769
I'm not so sure about the module names.
The parent is called.
`flink-streaming-connectors-parent`
The modules itself are called:
```diff
+
+
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/719#issuecomment-105926196
Should we so clearly differentiate between the streaming and the batch
connector projects?
Why not have a `flink-connector-kafka` that contains both a batch a
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/719#issuecomment-106203949
I added the `parent` suffix to the main pom, because that is how we tend to
name modules not containing source code themselves. Then I have realized that
the name is bec
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/719#issuecomment-106285952
Okay, I agree with you that we can name the modules the way marton
suggested it.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/719#issuecomment-106299970
Thanks, merging as soon as travis verifies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/719
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
