Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-133730158
I have created
[FLINK-2561](https://issues.apache.org/jira/browse/FLINK-2561) for the sync.
---
If your project is set up for it, you can reply to this email and have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-132115823
Looks good to merge except one cosmetic issue. Awesome job! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user PieterJanVanAeken commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-132118620
I fixed the unneccessary comment and did a quick rebase to keep up with
master branch.
---
If your project is set up for it, you can reply to this email and
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-132119301
All right, let's merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1004#discussion_r37273914
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1004
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-132241841
If the APIs are in sync there should be one documentation for both, right?
Similar as with the other APIs...
---
If your project is set up for it, you can reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-132235443
What are the plans for documenting the Gelly Scala API ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user PieterJanVanAeken commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-132252484
As mentioned, they are not in sync yet. We need to create an issue to
update the Scala API so that it is in sync with the Java API. A completeness
test should
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-131148744
Wow, looks like a good piece of work. Nicely with tests and everything.
Build also passes, style looks good.
+1 to merge this from my side. I'd like to
Github user PieterJanVanAeken commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-131156825
I would postpone adding the completeness check as it will currently fail.
Since I started working on this, the Java Gelly API has changed and while I
modified
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-131169939
+1 from me too. Thanks for your great work @PieterJanVanAeken!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1004#issuecomment-131158707
Sounds good.
If no one objects in the next days, I would merge this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user PieterJanVanAeken closed the pull request at:
https://github.com/apache/flink/pull/808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user PieterJanVanAeken opened a pull request:
https://github.com/apache/flink/pull/1004
[FLINK-1962] Add Gelly Scala API v2
Second version of the PR for the Scala Gelly API. For more information, see
PR #808
You can merge this pull request into a Git repository by running:
Github user PieterJanVanAeken commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-129424059
Opened up a second PR from a cleaned out repo. Closing this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-128638593
Right @chiwanpark, its the last commit not the PR as a whole. Thanks for
clarifying!
---
If your project is set up for it, you can reply to this email and have your
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-128638129
26 files for me as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-128638172
[Your last
commit](https://github.com/PieterJanVanAeken/flink/commit/463a1f30b3b0785f46c76f9c290da3deec26)
includes all updates of master branch. Please remove
Github user PieterJanVanAeken commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-128634451
Really? It says 26 files changed for me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-128681998
I think it's a good idea and it will probably save you time :) Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-128420592
Hi @PieterJanVanAeken! Thanks for the update. It seems something went wrong
with your merge. Your last commit shows 1000+ files changed... Could you try to
rebase instead?
Github user PieterJanVanAeken commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-127543254
So I fixed some of the issues and tried to merge with the master branch
again. Not sure if I did everything correctly though so if someone could check
this
Github user PieterJanVanAeken commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-125117571
@Vasia I have been a bit strapped for time but I should have some time this
week to work on this some more. If I am not done by the end of the week, you
can
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-125112165
Hey @PieterJanVanAeken!
Are you back working on this or would you rather someone else takes over?
I think I can find some time next week to resolve remaining issues
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-125120680
Nope, I think that's spot on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-125132370
Perfect, thanks @PieterJanVanAeken!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user PieterJanVanAeken commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-114468380
Hi,
Thanks all for the comments. Unfortunately, I will be gone until the 13th
of July so I will not be able to resolve these issues until then. They
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-114426618
Oh, one more thing :)
In order to make this work in Eclipse, I had to add a few lines to the
pom.xml.
Basically, I copied the `build` block from the streaming-scala
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-114412170
ExecutionEnvironment.scala, UnionOperator.java and Graph.java have a lot of
whitespace/formatting changes. This makes it hard to see the actual changes to
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-114420568
Thanks @aljoscha for reminding me... This slipped my mind for a sec.
I agree that the methods should have Scaladoc (this should be
straightforward to add
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-113150313
Yes, the formatting would indeed have to be changed to conform to the
pre-existing Flink Scala style.
---
If your project is set up for it, you can reply to this email
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-113147981
Hi. I'm very excited about Gelly's Scala API. I'm reading the changes from
this PR. I found a problem about re-formatting. Unlike Flink's Java code,
Flink's Scala
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-110664776
I will thoroughly check it once the release that is currently happening is
done. Then people can check it out and it will have had some expose before
releasing it in
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-110448745
I am super excited about this one! :) Will also have a look in the next
days! Awesome job!
---
If your project is set up for it, you can reply to this email and have
GitHub user PieterJanVanAeken opened a pull request:
https://github.com/apache/flink/pull/808
[FLINK-1962] Add Gelly Scala API
Pull request for adding the Gelly Scala API. There were some issues with
rebasing due to both the Java Gelly API and the Testing API changing, so if
36 matches
Mail list logo
