Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/674#issuecomment-107392647
Looks good!
Will merge this..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/674#issuecomment-105951860
I have those unit test style tests all in the KafkaITCase because they
depend on the testing clusters started for the test.
They all need at least a running Zookeeper
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/674#issuecomment-105926083
Sorry for not reacting. I was busy with other stuff but I'll now address
your comments.
---
If your project is set up for it, you can reply to this email and have your
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/674#issuecomment-105846281
What is the status of this pull request? Any pending changes, or is it
blocked by anything?
---
If your project is set up for it, you can reply to this email and hav
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/674#discussion_r30787324
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/persistent/PersistentKafkaSour
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/674#discussion_r30787289
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/persistent/PersistentKafkaSour
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/674#issuecomment-104206104
Looks good. Some of the tests look like unit-style tests that are sort of
lightweight.
May be good to pull those out in to a `PersistentKafkaSourceTest`-
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/674#discussion_r30787124
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/persistent/PersistentKafkaSour
