[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1223 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-07 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1223#issuecomment-146149898 OK, will merge this one. Thanks for the quick update @WangCHX! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1223#issuecomment-146139386 Thanks for addressing the comments! Looks very good now, +1 to merge this --- If your project is set up for it, you can reply to this email and have your re

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-06 Thread WangCHX
Github user WangCHX commented on a diff in the pull request: https://github.com/apache/flink/pull/1223#discussion_r41349716 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java --- @@ -199,6 +199,31 @@ public int getNumberOfExecutionRetries() {

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-06 Thread WangCHX
Github user WangCHX commented on a diff in the pull request: https://github.com/apache/flink/pull/1223#discussion_r41349706 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/Plan.java --- @@ -303,6 +303,13 @@ public int getNumberOfExecutionRetries() { }

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-06 Thread WangCHX
Github user WangCHX commented on a diff in the pull request: https://github.com/apache/flink/pull/1223#discussion_r41349717 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java --- @@ -199,6 +199,31 @@ public int getNumberOfExecutionRetries() {

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-06 Thread WangCHX
Github user WangCHX commented on a diff in the pull request: https://github.com/apache/flink/pull/1223#discussion_r41349100 --- Diff: docs/apis/programming_guide.md --- @@ -1992,6 +1992,8 @@ With the closure cleaner disabled, it might happen that an anonymous user functi

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-06 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1223#issuecomment-145789872 A good start. I think for the batch API, there is a step missing, which sets the parameter on the `JobGraph`, in the `JobGraphGenerator`. The streaming and

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-06 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1223#discussion_r41239431 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/Plan.java --- @@ -303,6 +303,13 @@ public int getNumberOfExecutionRetries() { }

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-06 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1223#discussion_r41239441 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java --- @@ -199,6 +199,31 @@ public int getNumberOfExecutionRetries() {

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-06 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1223#discussion_r41239449 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java --- @@ -199,6 +199,31 @@ public int getNumberOfExecutionRetries() {

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-06 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1223#discussion_r41239329 --- Diff: docs/apis/programming_guide.md --- @@ -1992,6 +1992,8 @@ With the closure cleaner disabled, it might happen that an anonymous user functi

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-05 Thread WangCHX
Github user WangCHX commented on the pull request: https://github.com/apache/flink/pull/1223#issuecomment-145740461 Thank you very much. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-05 Thread WangCHX
Github user WangCHX commented on the pull request: https://github.com/apache/flink/pull/1223#issuecomment-145733727 Thank you. Sure. I will do it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1223#issuecomment-145708133 Thanks a lot for your contribution to Flink! Sorry for not giving you feedback earlier. Many committers are currently busy preparing the next Flink release.

[GitHub] flink pull request: [FLINK-2066][core] Add delay between execution...

2015-10-04 Thread WangCHX
GitHub user WangCHX opened a pull request: https://github.com/apache/flink/pull/1223 [FLINK-2066][core] Add delay between execution retires configuration … …at job level want to solve FLINK-2066. Based on when there has number of retries, there must has retry delay. Add