[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...

2015-05-26 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/726 [FLINK-2096] Remove implicit conversion from Window Stream to Stream This causes unexpected behaviour, for example in: ds.window(...).map(..) The user would expect some kind of wind

[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...

2015-05-26 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/726#issuecomment-105598384 The reason for having this was that then the conversion is seamless. As seen in the relevant [question](http://stackoverflow.com/questions/30461809/in-flink-stream-windo

[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...

2015-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/726#issuecomment-105841951 +1 from my side. I think it is important that the core APIs let you see clearly what is happening, otherwise new users usually get thrown off. --- If your

[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...

2015-05-28 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/726#issuecomment-106237798 manually merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] flink pull request: [FLINK-2096] Remove implicit conversion from W...

2015-05-28 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/726 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena