Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/814#issuecomment-114860764
I did not mean a special Kryo serializer but our very own
`WritableSerializer`. With the current implementation `WritableTypeInformation`
has precedence over
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/814#issuecomment-114863239
@rmetzger suggested to add a specialized Kryo serializer for the `Writable`
interface. That way we could directly call the write method of `Writable` types
which
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/814#issuecomment-114501534
I don't think Kryo is handling classes implementing `Writable` in a special
way.
It should be trivial to add a special Kryo serializer for it (see also
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/814#issuecomment-114424839
Ah, okay. I was not aware that they are handled by a special writable
serializer (that is subclass aware) and that still uses the writable logic. Is
it s special
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/814#issuecomment-114080543
I am unsure of where this leads us. The purpose of `Writable` is to make
sure that we can use the Writable's custom serialization. If the type
`Writable` itself is
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/814#issuecomment-114232368
The subtypes of `Writable` are still serialized using the special
`Writable` serializer. However, there are situations where you only have a
`Writable` type, e.g.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/814#issuecomment-114236910
Moreover, it would be inconsistent IMO with the rest of the typing system.
Sometimes interfaces are supported and sometimes not. For the user, this might
be
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/814
[FLINK-2194] [type extractor] Treats Writable type as generic type
(interface)
Adds check so that the `Writable` type is treated as a generic type.
You can merge this pull request into a Git
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/814#issuecomment-110664983
Travis gives green light. Will merge since it's a trivial fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/814
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
10 matches
Mail list logo
