Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/867
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-140223417
OK, I will close this PR tomorrow, unless somebody speaks up.
@Shiti, I am sorry for the time you invested in this PR, but we cannot add
it to Flink's codebase
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-140018844
Yes, I'm afraid it's better to close it and provide an alternative for the
Table API, for example.
---
If your project is set up for it, you can reply to this email
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-139547674
I agree with @StephanEwen that the TupleSerializer should not support null
values. However, it might be good to offer a null-aware alternative.
Can we close this PR
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-116520207
@Shiti No need to apologize, that is all right. We are discussing a tricky
thing here...
It is true, right now, one needs to be aware of missing values in
Github user Shiti commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-115936916
@StephanEwen, Apologies, I didn't notice the earlier message in jira.
Something wrong with my GMail settings, most of the messages from jira and
mailing list went into
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-115228662
Also, apparently no tests were ever run after these changes. All fail on
the build server on basic checkstyle rules even.
---
If your project is set up for it, you
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-115248743
@StephanEwen hinted that the best way to go would be to decuple the
RowTypeInfo completely from the TupleTypeInfo/TupleSerializerBase. This way, we
get null-value
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-115227753
We actually had a discussion about this quite a few times. I also raised my
concerns in the discussion of the issue, to which no one reacted.
The
GitHub user Shiti opened a pull request:
https://github.com/apache/flink/pull/867
[FLINK-2230] handling null values for TupleSerializer
When serializing, we add a `byte[] (BitSet.toByteArray)` before the fields
which indicates `null` fields.
When deserializing, we fetch
10 matches
Mail list logo
