[GitHub] flink pull request: [FLINK-2379][ml]Add column wise statistics for...

2015-12-08 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1032#issuecomment-162821875 How about base class with declaration of the both statistics values and child class with the implementation of that values? ```scala abstract class

[GitHub] flink pull request: [FLINK-2379][ml]Add column wise statistics for...

2015-12-07 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1032#issuecomment-162550968 Hi @chiwanpark, thanks for picking this up. :) Since a `Vector` might contain discrete fields as well as continuous fields, we need to have a

[GitHub] flink pull request: [FLINK-2379][ml]Add column wise statistics for...

2015-12-07 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1032#issuecomment-162506577 I would like to shepherd this pull request. Sorry for long delay. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2379][ml]Add column wise statistics for...

2015-12-07 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1032#issuecomment-162518625 Hi @sachingoel0101, I just reviewed quickly. I have some questions and comments for this pull request. First, why `FieldStats` covers statistics value for

[GitHub] flink pull request: [FLINK-2379][ml]Add column wise statistics for...

2015-12-07 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1032#issuecomment-162519456 Additionally, if you will modify your pull request, please do not rebase the commit because I'm tracking your branch (`sachingoel0101/flink.git/statistics`). We can

[GitHub] flink pull request: [FLINK-2379][ml]Add column wise statistics for...

2015-11-12 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1032#issuecomment-156147916 Ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2379][ml]Add column wise statistics for...

2015-09-02 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1032#issuecomment-136978688 @tillrohrmann , can you review this? This will be a starting point for a package to provide more statistical methods, such as hypothesis testing, correlation,

[GitHub] flink pull request: [FLINK-2379][ml]Add column wise statistics for...

2015-08-18 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1032 [FLINK-2379][ml]Add column wise statistics for vector Data Sets This is because of splitting the work in #861 in two parts. You can merge this pull request into a Git repository by running: