GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1628
[FLINK-2444] add tests for HadoopInputFormats
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mliesenberg/flink
FLINK-2444-input-format-tes
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1628#issuecomment-183291368
3 builds failed:
- one due to [FLINK-2719](https://issues.apache.org/jira/browse/FLINK-2719)
([log](https://s3.amazonaws.com/archive.travis-ci.org/jobs/108744342/
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1628#discussion_r56966658
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/hadoop/mapreduce/HadoopInputFormatTest.java
---
@@ -20,22 +20,137 @@
import org.apach
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1628#issuecomment-199757394
Hi @mliesenberg, sorry for the late review. Tests look really good.
I think there is one auto-completion error in the code (see inline comment).
I will run a
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1628#issuecomment-199788556
thanks for the review, addressed the comment, squashed and rebased on master
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1628#discussion_r57137711
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/hadoop/mapred/HadoopInputFormatTest.java
---
@@ -20,21 +20,154 @@
import org.apache.f
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1628#discussion_r57137819
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/hadoop/mapreduce/HadoopInputFormatTest.java
---
@@ -20,22 +20,137 @@
import org.apach
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1628#discussion_r57137864
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/hadoop/mapreduce/HadoopInputFormatTest.java
---
@@ -20,22 +20,137 @@
import org.apach
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1628#issuecomment-200289093
Found just a few style issues. Otherwise good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1628#issuecomment-200337562
Thanks for the quick update. Will merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1628
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
11 matches
Mail list logo
