[GitHub] flink pull request: [FLINK-2478]fix the array may have out of boun...

2015-08-15 Thread Rucongzhang
GitHub user Rucongzhang opened a pull request: https://github.com/apache/flink/pull/1021 [FLINK-2478]fix the array may have out of bounds In getNestedDelta function, the array length of oldDatapoint and the array length of newDatapoint are notbeen ensured same.So add the judgem

[GitHub] flink pull request: [FLINK-2478]fix the array may have out of boun...

2015-08-15 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1021#issuecomment-131402990 If the two arrays are of different lengths, should this throw an exception? After all, the cosine distance is not well defined then and returning 0 may give the impr

[GitHub] flink pull request: [FLINK-2478]fix the array may have out of boun...

2015-08-15 Thread Rucongzhang
Github user Rucongzhang commented on the pull request: https://github.com/apache/flink/pull/1021#issuecomment-131493503 Yes,stephan it should throw an exception.I will modify .Thank you very much! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2478]fix the array may have out of boun...

2015-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1021 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab