[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-130388161 No worries =) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-130369569 I thought not, but you are right, I pushed the wrong branch. Sorry, git-fail on my side! I'll push an update in a bit... --- If your project is set up f

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-130362926 HI @StephanEwen why is this PR is merged without addressing existing comments? --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1008 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1008#discussion_r36834144 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java --- @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Softwa

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-12 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-130206616 Very nice addition! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-11 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-130154250 Agree with Max, this should be useful. Other than small nit on message +1 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-11 Thread hsaputra
Github user hsaputra commented on a diff in the pull request: https://github.com/apache/flink/pull/1008#discussion_r36825210 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/StreamConfig.java --- @@ -198,12 +199,26 @@

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-129955067 Good comment, will adjust this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-129947817 This is great and will be very helpful while debugging! Only the output is very hard to read. How about this? Just some new lines and indention: ``` Cannot load user

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

2015-08-11 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/1008 [FLINK-2509] Add class loader info to exception message when user code classes are not found This pull request adds the following type of info to the exception message: ``` Cannot l