[GitHub] flink pull request: [FLINK-2526]Add try-catch for task when it sto...

2015-08-15 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/1020#issuecomment-131495368 @StephanEwen Thanks. I think you pull request has fixes this.I will close my pull request and view your code. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2526]Add try-catch for task when it sto...

2015-08-15 Thread ffbin
Github user ffbin closed the pull request at: https://github.com/apache/flink/pull/1020 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-2526]Add try-catch for task when it sto...

2015-08-15 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1020#issuecomment-131390701 The pull request #1017 actually fixes this as well, together with a lot of other things (similar problems are in many places). Can you have a look at #1017 a

[GitHub] flink pull request: [FLINK-2526]Add try-catch for task when it sto...

2015-08-15 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/1020#issuecomment-131314931 @zentol Hello! Thank you for your suggestion.I have add exception message in log. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] flink pull request: [FLINK-2526]Add try-catch for task when it sto...

2015-08-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1020#discussion_r37134398 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTask.java --- @@ -100,9 +100

[GitHub] flink pull request: [FLINK-2526]Add try-catch for task when it sto...

2015-08-15 Thread ffbin
GitHub user ffbin opened a pull request: https://github.com/apache/flink/pull/1020 [FLINK-2526]Add try-catch for task when it stop running inputProcessor cleanup() may throw IOException.If do not catch it, the next line outputHandler .flushOutputs() will not work and cause output da