Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1059
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-138493194
Now it's merged. This time for real :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-138482074
Thanks for your contribution @tammymendt. You pull request has been merged
but the auto-close didn't work :) Could you close the pull request?
---
If your project is set
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-138484531
Pending merge... it is in my travis branch, tests ran over night...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-138484565
Oh sorry, that was a reference from Stephan's repository.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-138483365
Is this merged? I cannot find this commit in ASF Git repository.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-138305084
Looks good, merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-135367172
Agree with Fabian. Other then the inline comments and the documentation,
this looks good.
---
If your project is set up for it, you can reply to this email and
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1059#discussion_r38076964
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -445,7 +445,12 @@ protected int skipFields(byte[]
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1059#discussion_r38077040
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -445,7 +445,12 @@ protected int skipFields(byte[]
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1059#discussion_r38077190
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java
---
@@ -984,7 +984,7 @@ public void
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-135365195
This PR should also update documentation of the CSV parser (see Data
Sources section in programming_guide.md).
Thanks, Fabian
---
If your project is set up
GitHub user tammymendt opened a pull request:
https://github.com/apache/flink/pull/1059
[FLINK-2567]
Allow quoted strings in CSV fields to contain quotation character inside of
the field, as long as its escaped Ex: 'Hi my name is \'Flink\' '. If a
quotation character is found,
13 matches
Mail list logo
