[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-11 Thread willmiao
Github user willmiao closed the pull request at: https://github.com/apache/flink/pull/1107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-11 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-139531959 I'm sorry that something went wrong with my original repository. So, I open a new PR, and this one will be closed. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138885088 I agree with your proposal! If `yarn.defaultNumberOfTaskManagers` is set to an invalid value, we should make `-n` required. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread willmiao
GitHub user willmiao opened a pull request: https://github.com/apache/flink/pull/1107 [FLINK-2591]Add configuration parameter for default number of yarn containers https://issues.apache.org/jira/browse/FLINK-2591 Add configuration parameter for default number of yarn containers

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138600722 Thanks a lot for opening the pull request. Can you change the behavior of this a little bit to make the `-n` argument a required argument again? (if the config

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138772421 Hi rmetzger, I've got a question: what if yarn.defaultNumberOfTaskManagers is set to a invalid value, say -2? Should user have to supply the -n argument? --- If your

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138774833 Hi rmetzger, I've got a question: what if yarn.defaultNumberOfTaskManagers is set to a invalid value, say -2? Should users have to supply the -n argument? I

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138603922 Thanks for your advices, I'll fix it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project