Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rerngvit commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145629889
Thanks all for suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145575983
Thanks :). I'm going to merge this (I will insert the missing line breaks).
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145505679
I also meant the alignment. You need more newlines for `succeeded` and
`failed`.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user rerngvit commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145501938
@uce I added the new line according to your hint.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145484206
The alignment gets thrown off. You can correct this with Ufuk's hint,
adding a newline at the very beginning.
---
If your project is set up for it, you can reply to
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1221#discussion_r41115826
--- Diff: flink-core/src/test/java/org/apache/flink/util/TestLogger.java ---
@@ -37,23 +37,26 @@
@Override
public void starti
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145406603
Thanks for second pair of eyes :)
How the output result is different?
The patch just make sure logging of all messages happen in single log call
---
If your pr
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145401720
I'm not sure this patch is ready to merge. Because of additional components
for log such as time, thread name, caller class name, etc., the log output is
not same aft
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-14536
Thanks for the patch update. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145399785
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user rerngvit commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145364699
The build is failed on an issue not related to the PR.
In particular, it failed only on "JDK8 Hadoop 2.5" with
"java.io.FileNotFoundException: build-target/lib/fl
Github user rerngvit commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145325375
@hsaputra Thanks for your review. I modified this PR according to your
comment.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145315514
Unfortunately looks like this patch does not take advantage of slf4j
parameterized logging [1].
Either do like:
log.info("=
GitHub user rerngvit opened a pull request:
https://github.com/apache/flink/pull/1221
[FLINK-2741] - Use single log statement in TestLogger
[FLINK-2741] - Use single log statement in TestLogger
You can merge this pull request into a Git repository by running:
$ git pull https:/
15 matches
Mail list logo
