Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-156094351
@mxm , should be ready to merge now. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44645434
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/DetachedEnvironment.java
---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the A
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44645161
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/DetachedEnvironment.java
---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softw
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44643881
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/DetachedEnvironment.java
---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the A
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44641729
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/DetachedEnvironment.java
---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softw
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155861149
@mxm , rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155842188
There is a merge conflict. Looks good otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155764884
Okay. Figured it out. The Parallelism in the `ContextEnvironment` wasn't
being respected in `StreamContextEnvironment`. Passes on my local machine now;
waiting fo
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155717073
@mxm , fortunately, this time I was able to run the tests on my machine. :)
I'm seeing a strange error. This is the error in Task manager log file for
per job
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155391848
>Do you know of any change I can make to travis conf so all modules are
built but only Yarn tests get executed?
Yes change the build instructions in .travis.yml to
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155385085
>>> You're probably right. It may just seem odd to the user that code gets
executed even though the job won't be submitted. We might fix that in the
future if use
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155381011
Looks like your recent changes broke the YARN tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155373495
>This is a full fledged execution of the use code, and should show any user
generated out and err messages in my opinion.
You're probably right. It may just seem odd
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155138232
Of course, anything Flink will print, say, log messages, will already be
disabled as there is no actor to receive the messages.
---
If your project is set up for
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155137822
I'm not sure why we should do this in Detached mode. When `info` is run,
user has only directly explicitly requested the plan. This is a full fledged
execution of
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155059238
Yes, the idea is suppress output during the dry-run and plan creation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155052238
When the main method is invoked via
`PackagedProgram#invokeInteractiveModeForExecution`, it executes everything,
and the flink plan it builds is stored in the `De
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155047586
Thanks for the timely update @sachingoel0101.
I was referring to the acquisition of the plan. When we create the plan,
(e.g. ./bin/flink info JAR) we suppress print
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-155043211
Hi @mxm , I'm not sure about directing sysout and syserr to null. Detached
mode just means flink jobs are being run in detached mode; the rest of the
program shou
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-154428753
There are still two issues I noticed. Printing to standard out should be
disabled during the dry-run phase. Just like in the OptimizerPlanEnvironment.
The other one is Conte
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44126978
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
---
@@ -114,15 +115,33 @@ public Client getClient() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44117608
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
---
@@ -114,15 +115,33 @@ public Client getClient() {
publi
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44117601
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
---
@@ -114,15 +115,33 @@ public Client getClient() {
publi
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-154339878
Failure on an unrelated test: JobManagerSubmittedJobGraphsRecoveryITCase
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44051406
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -81,13 +60,15 @@ public J
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44044799
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -81,13 +60,15 @@ public J
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r44040745
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -81,13 +60,15 @@ public JobExecution
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-153690460
That's a good point. It might inadvertently break things.
For the release candidate, how about including just the first part, i.e.,
just the detached mode for
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-153689197
I'd like to merge this on the master but I don't think it should be
included in 0.10 because it is too big of a change for a release candidate.
Additionally, it's not a pres
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-153599182
Build passes. Let's include this in the next rc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-153381184
Cool. :)
Squashing commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-153377995
Looks good @sachingoel0101. Good to merge from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43753100
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -81,13 +60,13 @@ public J
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43750488
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -81,13 +60,13 @@ public JobExecution
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-153094985
@mxm , I've made some modifications and removed `ClassLoader` code from the
`StreamContextEnvironment`.
Further, made the code branch to set the `lastEnv` mor
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43635433
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
---
@@ -165,12 +181,65 @@ public ContextEnvironmentFactory(Client c
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-152990620
The lastEnv is set for blocking also, because it still makes sense. It just
stores what the last environment created by the factory was.
I worked on this a whi
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-152989560
It's fine to have separate code for detached and blocking submission where
necessary. I was more concerned with this pull request that it introduces new
code branches which
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-152987728
@mxm , there is a lot of code duplication between the detached and blocking
submission modes. I'm gonna try to clean that up while I address your concerns.
Doe
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-152973475
Thanks for adapting the pull request to the latest master. It is in better
shape now but I still think it can be improved. Please make sure there is an
explicit way to submi
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43610508
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
---
@@ -165,12 +181,65 @@ public ContextEnvironmentFactory(Client c
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43610296
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -36,28 +31,16 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43609728
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -75,29 +62,31 @@ public JobExecution
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43609625
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -36,28 +31,16 @@
priva
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43600897
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -36,28 +31,16 @@
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-152934449
@mxm, since you already delegated job graph creation to the Client in one
of your commits, I've removed that from my commits. Rebasing required squashing
all comm
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43498784
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -75,29 +62,31 @@ public JobExecution
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43273230
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -271,18 +272,21 @@ public JobSubmissionResult
runDetached(PackagedProgra
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151849439
@mxm , if there are any more comments, let me know. I'll try to resolve
them quickly so we can include this in the next rc (which will likely be the
last one(?)).
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151458018
@mxm , I have tested the build with the following commands:
1. Standalone cluster: `bin/flink run -d` for both streaming and batch
wordcount examples.
2. Y
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151435402
Agreed. I'll build and test with the example programs in standalone mode
and on yarn. It should work perfectly though since `YarnSessionFIFOITCase`
checks both ba
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151430438
Thanks. Looks much better. Let's make sure we don't break any classloader
or jar dependencies during job submission. This can cause annoyances for users
and we have to fix i
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098720
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -909,7 +919,21 @@ private int handleError(Throwable t) {
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098424
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -271,18 +272,21 @@ public JobSubmissionResult
runDetached(Pac
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098367
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -75,29 +62,31 @@ public J
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098234
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -271,18 +272,21 @@ public JobSubmissionResult
runDetached(PackagedProgra
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098268
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -909,7 +919,21 @@ private int handleError(Throwable t) {
}
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098098
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -75,29 +62,31 @@ public JobExecution
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43098099
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -75,29 +62,31 @@ public JobExecution
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151402904
@mxm I have made some changes and now the *current* plan resides in the
`ContextEnvironment`. This required some changes in `StreamContextEnvironment`,
which now
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-151224527
I took a look at this again because I wanted to merge it for 0.10. However,
I think it still needs a bit of work. The `ContextEnvironmentFactory` shouldn't
hold the state fo
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43015201
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -304,4 +368,60 @@ public String getDescription() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42979520
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -304,4 +368,60 @@ public String getDescription() {
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42886049
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -304,4 +368,60 @@ public String getDescription() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42884467
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -304,4 +368,60 @@ public String getDescription() {
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42882261
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -304,4 +368,60 @@ public String getDescription() {
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42882120
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -139,6 +141,69 @@ public void shouldSubmitToJobClient() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42879750
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -304,4 +368,60 @@ public String getDescription() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42879700
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -139,6 +141,69 @@ public void shouldSubmitToJobClient() {
}
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-150299549
@mxm , I have addressed some of your comments.
Two things still remain: batch + stream jobs, and better tests. Need advice
on those.
---
If your project is
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42778575
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -139,6 +140,69 @@ public void shouldSubmitToJobClient() {
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42774775
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -304,4 +368,60 @@ public String getDescription() {
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42774659
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -139,6 +140,69 @@ public void shouldSubmitToJobClient() {
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42774635
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -139,6 +140,69 @@ public void shouldSubmitToJobClient() {
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42774405
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
---
@@ -161,6 +171,8 @@ public ContextEnvironmentFactory
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42774255
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -277,12 +278,20 @@ else if (prog.isUsingInteractiveMode()) {
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-150283627
Thanks for the update @sachingoel0101. I've made some comments. I think the
pull request needs a bit of cleanup to make things more explicit. The general
approach looks good
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42772695
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -304,4 +368,60 @@ public String getDescription() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42772667
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -139,6 +140,69 @@ public void shouldSubmitToJobClient() {
}
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42772661
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ---
@@ -139,6 +140,69 @@ public void shouldSubmitToJobClient() {
}
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42772634
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
---
@@ -161,6 +171,8 @@ public ContextEnvironmentFactory(Client cli
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42772606
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
---
@@ -172,5 +184,74 @@ public ExecutionEnvironment
createExecuti
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r42772489
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -277,12 +278,20 @@ else if (prog.isUsingInteractiveMode()) {
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-149172503
The test failures are on the flaky scala shell integration test.
@mxm @StephanEwen , can you take a look at this so we can add proper
documentation to the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-147997899
Failures on unrelated cases: JIRA 2847, and the scala shell test is flaky.
Till is working on it.
---
If your project is set up for it, you can reply to this ema
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-147235260
Seems like each build fail in different places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-147114132
@hsaputra Yes. However, the travis build log doesn't display the exact
cause of the failure. In the code, there is code to log the file with
prohibited strings at
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-147112611
@sachingoel0101 , could you access this URL:
https://travis-ci.org/apache/flink/jobs/84664370
You could always set your own Apache Flink forked repo. That way y
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-147091911
I tested this out on yarn and without yarn. Works like a charm.
However, the travis builds are failing in `flink-yarn-tests`. Is there any
way I can access th
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146980054
@mxm @StephanEwen I have an implementation ready. I have also added unit
tests to verify the behavior. Let me know if this is an acceptable way. All the
relevant
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146918295
Good points.
I think that should do it, Sachin. Curious, how you'll implement it :)
Don't we run into the problem that we never know if another execution followed
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146914064
There are three root causes(please add if I've missed any.)
1. Call to execute twice
2. Access job execution results.
3. Executing one of the eager exec
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146913514
IMO even removing the detached mode might be better than restricting to
`Program` interface. Instead of failing late in the execution, or with a
non-informative w
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146912518
We can go with the `Program` interface ,but I think that is such a heavy
restriction that this effectively renders the feature useless...
---
If your project is set
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146911998
With proper documentation, failing on the second execute could be an
acceptable workaround but it's bound to cause trouble. In addition we might
want to warn users on the co
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146911063
I think we need to ensure that interactive programs which can execute
successfully should still be allowed.
What I proposed should work. I can push a commit an
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146909986
I would solve it pragmatically and simply make the Program interface a
requirement for detached programs. Otherwise, fail with an explanation.
---
If your project is set up
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146909628
This will fail hard when users rely on the result of the first job. So
imagine your program always worked. You submit it detached and then it fails
after 12 hours when the f
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-146908658
The way we do this with the Optimizer plan is a bit pragmatic. We wick the
first runnable part and use that. We could do the same here. Detached mode
would submit th
1 - 100 of 125 matches
Mail list logo
