[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-03 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1222 [FLINK-2798] Serve static files for the new web frontend from the classloader This pull request is based on https://github.com/apache/flink/pull/1202. In order to make the new web interfac

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-05 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1222#issuecomment-145488471 I gave some comments on the commit. Looks mainly good, I am only confused why you changed all request URLs to relative from absolute. This may have other imp

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1222#issuecomment-145733149 Thank you for the review. I'm trying to update the PR within the next 24 hours Sorry for not explaining why I changed all the request URLs to relative paths: When a

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-07 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1222#issuecomment-146151414 Note: We have to check the startup logic of my changes in the YARN case as well (either in this PR or the other one). --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-07 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1222#issuecomment-146400367 I will wait until your pull request is merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-15 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/1222 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] flink pull request: [FLINK-2798] Serve static files for the new we...

2015-10-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1222#issuecomment-148369010 Max took the relevant changes from this PR into https://github.com/apache/flink/pull/1246. Closing ... --- If your project is set up for it, you can reply to this emai