Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-206214656
I will close this issue in favor of the new design `TableDef` design.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user twalthr closed the pull request at:
https://github.com/apache/flink/pull/1237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-205881346
@twalthr is this still valid with the changes in the Table API or can it be
closed?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-162654340
You are right of course and I'm sorry I didn't put in the required time
earlier.
Your are also right about the Calcite thing. If we decide to use calcite
and h
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-162622155
So basically what you want to say is: throw your entire code away.
I'm disappointed that you think about the whole concept now, after I have
rebased and reworked the
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-162553706
Yes, we should, this has been lying around for a while now.
I have been thinking about this for a while now and I'm afraid I cannot
recommend to merge this in t
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-162521847
@aljoscha we should finally reach a consesus for this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-159229093
Most input formats won't use the adaptive sources. Sure performance is not
that important in the pre-flight phase, but if we always think so, the
pre-flight phase will s
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-159215435
I think the performance of the pre-flight phase is mostly irrelevant, even
if it is slow no-one will notice since it only runs once before the job starts.
IMHO, simplic
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-158955674
@aljoscha I thought it makes sense to distinguish between
`AdaptiveTableSource` and `StaticTableSource`. Calculating the predicates to be
pushed down is quite expensive,
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r45602715
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/PredicatePushdown.scala
---
@@ -0,0 +1,120 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r45602446
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/PredicatePushdown.scala
---
@@ -0,0 +1,120 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r45602245
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/PredicatePruner.scala
---
@@ -0,0 +1,88 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r45601201
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/TableEnvironment.scala
---
@@ -45,7 +60,12 @@ class TableEnvironment
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r45601100
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/TableEnvironment.scala
---
@@ -45,7 +60,12 @@ class TableEnvironment
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r45600975
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaStreamingTranslator.scala
---
@@ -113,8 +131,14 @@ class JavaStre
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r45600858
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaStreamingTranslator.scala
---
@@ -53,6 +55,22 @@ class JavaStream
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r45600839
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaBatchTranslator.scala
---
@@ -118,6 +135,12 @@ class JavaBatchTra
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r45600786
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaBatchTranslator.scala
---
@@ -54,6 +55,22 @@ class JavaBatchTrans
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-155719774
Why is it `AdaptiveTableSource` and `StaticTableSource`? Aren't static
sources a subset of adaptive sources that just don't adapt?
I don't think we need to have
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r44515720
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/ExecutionEnvironment.scala
---
@@ -64,15 +62,19 @@ import scala.reflect.ClassTag
* cr
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-155500029
Yes, sorry for the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-155498508
@aljoscha Do you think you'll find time this week for the PR? All Table API
input formats are waiting for it...
---
If your project is set up for it, you can reply to t
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-153709718
Yeah looks good now :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1237#issuecomment-153708732
I want to have a final look today. Is the Scala ok from your side now,
@tillrohrmann?
---
If your project is set up for it, you can reply to this email and have your
r
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r43872771
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,79 @@
+/*
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r43742661
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,79 @@
+/*
+
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r43631877
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,79 @@
+/*
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r43628710
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,75 @@
+/*
+
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r43590351
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,75 @@
+/*
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r43542701
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,75 @@
+/*
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r43541584
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,75 @@
+/*
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r43541130
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaBatchTranslator.scala
---
@@ -39,7 +40,7 @@ import org.apache.flink.ap
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r42603373
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/PredicatePruner.scala
---
@@ -0,0 +1,88 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r42603257
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,75 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r42603297
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,75 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r42603082
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/FieldBacktracker.scala
---
@@ -0,0 +1,75 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r42602668
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaStreamingTranslator.scala
---
@@ -38,7 +40,7 @@ import org.apache
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1237#discussion_r42602646
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaBatchTranslator.scala
---
@@ -39,7 +40,7 @@ import org.apache.fli
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1237
[FLINK-2828] [table] Add interfaces for Table API input formats
This PR implements TableSources as described in FLINK-2828. It is an
uncoupling of #1127 for FLINK-2167. All feedback I got from @aljo
40 matches
Mail list logo
