Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1267#issuecomment-151208136
I'm going to merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1267#issuecomment-150560041
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1267#issuecomment-149825879
The `MutableHashTablePerformanceBenchmark` can be removed from
`flink-runtime` if it is added to `flink-benchmark`.
Otherwise looks good.
---
If your project i
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42597950
--- Diff: flink-benchmark/pom.xml ---
@@ -57,6 +57,13 @@ under the License.
${jmh.version}
provided
+
--- End dif
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1267#issuecomment-149763186
LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gallenvara commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42453815
--- Diff:
flink-benchmark/src/test/java/org/apache/flink/benchmark/runtime/operates/hash/MutableHashTablePerformanceBenchmark.java
---
@@ -0,0 +1,361 @@
Github user gallenvara commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42453717
--- Diff: flink-runtime/pom.xml ---
@@ -210,7 +210,7 @@ under the License.
${curator.version}
test
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42452733
--- Diff:
flink-benchmark/src/test/java/org/apache/flink/benchmark/runtime/operates/hash/MutableHashTablePerformanceBenchmark.java
---
@@ -0,0 +1,361 @@
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42452678
--- Diff: flink-runtime/pom.xml ---
@@ -210,7 +210,7 @@ under the License.
${curator.version}
test
Github user gallenvara commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42448562
--- Diff: flink-benchmark/pom.xml ---
@@ -57,6 +57,13 @@ under the License.
${jmh.version}
provided
+
+
Github user gallenvara commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42448388
--- Diff: pom.xml ---
@@ -163,6 +163,16 @@ under the License.
jar
test
+
--
Github user gallenvara commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42448095
--- Diff:
flink-benchmark/src/test/java/org/apache/flink/runtime/operators/hash/MutableHashTablePerformanceBenchmark.java
---
@@ -0,0 +1,360 @@
+/**
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42425635
--- Diff:
flink-benchmark/src/test/java/org/apache/flink/runtime/operators/hash/MutableHashTablePerformanceBenchmark.java
---
@@ -0,0 +1,360 @@
+/**
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42425486
--- Diff: flink-benchmark/pom.xml ---
@@ -57,6 +57,13 @@ under the License.
${jmh.version}
provided
+
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42425336
--- Diff: pom.xml ---
@@ -163,6 +163,16 @@ under the License.
jar
test
+
--- E
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42424858
--- Diff: flink-runtime/pom.xml ---
@@ -210,7 +210,12 @@ under the License.
${curator.version}
test
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1267#issuecomment-149116533
JMH result (We can choose the benchmark mode with througout,
averagetime,sampletime and so on.Also we can set the warmup and measurement
iteration number according to
GitHub user gallenvara opened a pull request:
https://github.com/apache/flink/pull/1267
[FLINK-2853] [tests] Apply JMH on MutableHashTablePerformanceBenchmark
class.
JMH is a Java harness for building, running, and analysing
nano/micro/milli/macro benchmarks.Use JMH to replace the
Github user gallenvara closed the pull request at:
https://github.com/apache/flink/pull/1261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1261#issuecomment-149077635
Hi, @gallenvara , i think this PR has bounded to FLINK-2848, while actually
it should link to FLINK-2853, you may need to close this one and open another
new PR for
21 matches
Mail list logo
