[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1321 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-30 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-160650305 Will merge this pull request... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-159682273 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-25 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-159655565 Hi @mxm, is there any further improvement needed on this? If not, I think it should be merged. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-09 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-155121224 I think it's fine that the boxes are not all the same size for large numbers.. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-08 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-154982472 That'll take up unnecessary space for labels with small values like, say, 3-4. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-07 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-154738818 @sachingoel0101 thank you for taking these tickets. This patch handles large counts quite nicely. The only negative I see is that the colored boxes are generally no lo

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-06 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-154411033 Ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-04 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-153700497 Here's a screenshot though: ![screenshot 52](https://cloud.githubusercontent.com/assets/8874261/10937618/2175022e-831a-11e5-8d4b-7ff5c5257fc5.png) IMO

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-03 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1321 [FLINK-2904][web-dashboard] Fix truncation of task counts when the number is large. @greghogan can you verify if this solves the problem? I cannot test with such large number of tasks direct