Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153305865
@StephanEwen Sorry, didn't see your post. I filed a follow-up JIRA for
this: https://issues.apache.org/jira/browse/FLINK-2957
---
If your project is set up for it, you can
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153303602
@StephanEwen , since this is already merged, I'll push another commit and
point you to it for merging.
---
If your project is set up for it, you can reply to thi
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153192822
Much better. Is there a way of making this thing look more like a button?
Right now it looks very much like a label and I would not think of trying to
click it...
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153089967
Sure. No problem. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1313#discussion_r43647947
--- Diff:
flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee ---
@@ -70,6 +70,10 @@ angular.module('flinkApp')
$interval.can
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1313#discussion_r43646999
--- Diff:
flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee ---
@@ -70,6 +70,10 @@ angular.module('flinkApp')
$i
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1313#discussion_r43646752
--- Diff:
flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee ---
@@ -70,6 +70,10 @@ angular.module('flinkApp')
$interval.can
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153068875
Here are the new screenshots:
Before:
![screenshot
36](https://cloud.githubusercontent.com/assets/8874261/10886974/a07aa41e-81aa-11e5-8734-1eee48f431c1.png
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153058657
Thank you for noticing that @mxm. Will push a commit to address all your
comments in a little while.
---
If your project is set up for it, you can reply to this
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153037113
I would like to merge this soon. Cancellation jobs from the web frontend
has been requested several times.
---
If your project is set up for it, you can reply to this email
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153033461
>Hovering over the cross reveals the word cancel.
Could we also have a button labelled "Cancel Job"? That way people don't
even have to hover over things to get the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-152977663
@StephanEwen that's a good point. I've already pushed a fix. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-152943948
This goes a bit against the idea of REST. If you "GET" a certain URL, it
should not affect the state of the system you query.
If we want to make that action
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-152904731
Hovering over the cross reveals the word cancel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-152847408
Thanks! Not sure users will see the "X" in the corner and understand it's
for cancelling jobs.
---
If your project is set up for it, you can reply to this email and have y
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1313
[FLINK-2939][web-dashboard] Add support to cancel jobs from the dashboard
Cancel button placement (open for discussion and/or any changes):
