[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-154032312 It should pop up again when the job gets in running state again. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-154032071 No I think that's fine. I was only concerned whether the button is visible after a restart because you remove the button while cancelling... --- If your project is set up f

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-154031559 A restarted job will get in running state, and that should allow it to be cancelled. Should I allow cancelling in the `RESTARTING` state as well? --- If your pro

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-154031203 Does the cancel button also work for jobs which have been restarted? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153713212 I've pushed the relevant commit. Should be good to merge. @mxm --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153710660 Yes, much better in my opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153695612  ![screenshot 50](https://cloud.githubu

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153693747 Some minor commenets. Could we remove the "x" from the button? I think it looks odd. While cancelling, could we display just "Cancelling..." without a button? --- If your

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153692433 Here are the new screenshots:  ![scre

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153675080 Fair enough, if that's the majority view. I'll push a commit later today for this. On Nov 4, 2015 3:53 PM, "Till Rohrmann" wrote: > +1 for @mxm

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153672916 +1 for @mxm suggestion to use a simple button like the +/- buttons. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153410706 @mxm , what about something like this? I think this is the most clear way of displaying it. ![screenshot 41](https://cloud.githubusercontent.com/assets/887426

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153394232 I meant a button like for the + - buttons but labelled "Cancel". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153392818 I don't understand. Simply a *cross* won't be any better than one with *cancel* right next to it. --- If your project is set up for it, you can reply to this ema

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153390926 Not really convinced by your changes. What about a normal button like the + - buttons? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1319#issuecomment-153320254 @StephanEwen Is this better? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2957][web-dashboard] Improve the appear...

GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1319 [FLINK-2957][web-dashboard] Improve the appearance of cancel button Here are the screenshots: ![screenshot 40](https://cloud.githubusercontent.com/assets/8874261/10906772/24df7000-824a-11