[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1327#issuecomment-155133555 @mxm , rebased. Should be good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-09 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1327#issuecomment-155119995 Could you rebase again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-05 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1327#discussion_r43997592 --- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee --- @@ -28,6 +28,32 @@ angular.module('flinkApp')

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-05 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1327#discussion_r43997949 --- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee --- @@ -28,6 +28,32 @@ angular.module('flinkApp')

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1327#issuecomment-154025813 PR looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-05 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1327#issuecomment-154123489 Thanks. Looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-05 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1327#issuecomment-154159578 Rebased to current master. Should be good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-04 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1327 [FLINK-2966][web-dashboard] Improve the way job duration is reported. Duration is now reported in the following manner: < 1 s: as ms, *eg.* 359ms [1 s, 1 m): as it is, *eg.* 20s