Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171975531
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171973655
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171735915
Makes sense. Smaller font size will probably do it then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171727541
I didn't notice before, but now I also see that it can feel strange when
you scroll down. The text looks right aligned relative to the top navigation
bar. But moving the sub
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171714637
I think one problem with a fixed navigation on the side is what happens if
the number of entries is so huge that the whole navigation menu cannot be
displayed witho
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171713856
Looks very nice @uce. Would it be possible to shift the left navigation bar
to the top of the main text corpus? It makes the main text corpus strangely
positioned and takes
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171252164
Thanks for the quick response, @uce.
+1 for 14px
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171251500
I'm in favour of the smaller font size (14px).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171250982
@fhueske The previous font size was 14 px, the changed version has 16 px. A
screenshot for comparison. Maybe it's OK with 14 px, because the text is
narrower now. If more pe
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-171245556
+1 for the restructuring! Looks much better now.
Regarding the font size, I am not sure. IMO, it is a bit too large but I
can see that the previous setting was too s
Github user darionyaphet commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-170973617
yes I just want to say svg text info is unreadable thank you for you reply .
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-170972816
I've checked and couldn't see a difference to the current docs
(https://ci.apache.org/projects/flink/flink-docs-master/internals/stream_checkpointing.html).
I didn't change
Github user darionyaphet commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-170964972
hi @uce I found another small problem :
[checkpointing.svg](http://uce.github.io/flink/internals/stream_checkpointing.html#state)
in stream_checkpointing.html is Pi
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-170938227
@darionyaphet Yes, but I would file it as a follow-up. Thanks for the
suggestion! :)
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user darionyaphet commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-170936876
[config.html](http://uce.github.io/flink/setup/config.html#common-options)
could restructure to table style ? It's maybe better and clearly :)
---
If your projec
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-170927567
@aljoscha OK, I'm OK with removing it if more people don't like it. No
problem.
@rmetzger: OK, I would also like to remove it completely or only link it
from the co
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-170926819
Thank you for improving the documentation.
I think we can entirely remove the "Docker Connector" section (which is, in
the current documentation "Docker contain
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-170926522
Very nice :dancer: :+1:
One thing I'm not sure about are the boxes around the TOC, however. I mean
the TOC under the headline that's visible in your third scr
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1499
[FLINK-3132] [docs] Initial docs restructure
This PR restructures the documentation by allowing pages with
sub-navigations and furthermore fixes some minor issues and adds small
utilities.
A p
20 matches
Mail list logo
