GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1464
[FLINK-3166] [runtime] The first program in ObjectReuseITCase has the wrong
expected result, and it succeeds
- TestEnvironment now honors configuration of object reuse
- Fixed reduce transform
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1464#issuecomment-165406987
A few comments:
* the change to the TestEnvironment is unnecessary; ObjectReuse is
enabled/disabled in the JavaProgramTestBase. it doesn't fix anything, removing
the
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1464#issuecomment-165499126
I haven't found a prohibition on returning the second input to a
user-defined reduce function. I think fixing this in code is preferable to
documenting the problem or
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1464#issuecomment-165501540
"Object reuse is configured in JavaProgramTestBase but must be set in the
ExecutionEnvironmentFactory by TestEnvironment. I don't see that any of the
many tests subclassi
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1464#issuecomment-165506005
TestEnvironment was only setting the parallelism when creating and
establishing the ExecutionEnvironmentFactory:
```
public void setAsContext() {
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1464#issuecomment-165516598
ooohhh...that's a problem. alrighty, your solution for that looks good.
actually, would you mind moving that into a separate PR so we can get it in
faster? this should be
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1464#issuecomment-165753852
Good catch. I think all of these changes look actually good.
Minor comment in-line, otherwise +1
---
If your project is set up for it, you can reply to this
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1464#discussion_r48017305
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/ObjectReuseITCase.java
---
@@ -124,26 +125,30 @@ public static String runProgr
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1464#issuecomment-167351562
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1464
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
10 matches
Mail list logo
