Github user twalthr closed the pull request at:
https://github.com/apache/flink/pull/1595
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-182390675
Hey @twalthr,
I merged this yesterday but the PR didn't automatically close. Could you
please close it manually? Thanks!
---
If your project is set up for it, you can
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-181955939
Thanks for the quick update @twalthr! Some tests are failing because the
wrong type of exception is expected. I'll fix those and then merge this.
---
If your project is s
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-181902296
I have added comments and fixed the string bug. I will solve the other
issues at the end of the week.
If you have no objections, you can merge the PR ;-)
---
If you
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52303126
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-181848000
Thanks for reviewing @fhueske.
I will comment my code more.
Regarding the splitting of the `CodeGenerator`, I think it is not that easy
because function
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52301780
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52301613
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52301458
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed to
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-181824403
Hi Timo, the PR looks really good :-)
I found the following issues / questions:
- Accessing of POJO fields might not work.
- Can you add method comments t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52293343
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52293004
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52291201
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed to
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1595
[FLINK-3226] Implement a CodeGenerator for an efficient translation to
DataSet programs
This PR implements a CodeGenerator for Table API on Calcite.
It includes the following:
- FilterI
14 matches
Mail list logo
