GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1632
[FLINK-3226] Translate logical joins to physical
This PR contains the logical to physical translation for joins.
- Joins with equality conditions only do not generate a join function.
- Joins w
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1632#discussion_r52826898
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -148,16 +148,24 @@ class CodeGenerator(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1632#discussion_r52826951
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetMap.scala
---
@@ -63,7 +63,7 @@ class DataSetMap(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1632#discussion_r52827003
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetJoinRule.scala
---
@@ -39,18 +49,80 @@ class DataSe
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1632#discussion_r52827029
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetJoinRule.scala
---
@@ -39,18 +49,80 @@ class DataSe
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1632#issuecomment-183957839
Thanks for the review @twalthr! I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1632#issuecomment-184113402
Thanks for the changes. Looks good to merge ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1632#issuecomment-184170164
Great, merging this also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user vasia closed the pull request at:
https://github.com/apache/flink/pull/1632
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
