Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-214883298
ok good to know @uce! Let me get back to it in a couple of weeks and make
it right, now it is a bit impossible to find time.
---
If your project is set up for it,
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-202818056
Thanks @StephanEwen and @uce for looking into it! I really appreciate it.
How about the following:
1. I update this PR with the patch that uses ListState
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-200909639
The core idea of this is very good, also the illustration is very nice.
After an offline chat with @senorcarbone, we concluded that a remaining
problem in
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1668#discussion_r57327419
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamIterationHead.java
---
@@ -17,43 +17,80 @@
package
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1668#discussion_r57321347
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -450,112 +450,121 @@ else if (operator != null) {
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1668#discussion_r57320231
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -450,112 +450,121 @@ else if (operator != null) {
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1668#discussion_r57319737
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -450,112 +450,121 @@ else if (operator != null) {
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-190279441
You can find an alternative version using `ListState` in the following
branch:
https://github.com/senorcarbone/flink/commits/ftloopsalt
So I noticed that
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-187827823
I can't really add anything to the timeout question :D
As for the snapshotting. I would go with the ListState as that potentially
provides very efficient
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-187825999
Thanks @tillrohrmann for the feedback!
I merged `ForwardingOneInputTask` into `StreamIterationSink`.
One more think I missed pointing out is that when
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-186174994
Great idea @senorcarbone. I also really like it :-)
I agree with @gyfora to include the logic of the
`ForwardingOneInputStreamTask` in the
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-186142276
Thanks Paris, I like the idea, it's a correct modification of the original
algorithm to make it much easier to implement on Flink for the price of
buffering more
GitHub user senorcarbone opened a pull request:
https://github.com/apache/flink/pull/1668
[FLINK-3257] Add Exactly-Once Processing Guarantees for Iterative
DataStream Jobs
# **[WIP]**
This is a first version of the adapted snapshot algorithm to support
iterations. It is
13 matches
Mail list logo
