Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1577
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1577#issuecomment-179231858
Addressed all comments and will merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1577#discussion_r51718424
--- Diff:
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java ---
@@ -298,6 +299,21 @@ public static void writeObjectToConfig(Object o,
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1577#discussion_r51717612
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/LegacyFetcher.java
---
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1577#discussion_r51717545
--- Diff:
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java ---
@@ -298,6 +299,21 @@ public static void writeObjectToConfig(Object o,
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1577#issuecomment-178685691
Thanks for the review. Will merge it once Travis gives green light.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1577#discussion_r51597662
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/LegacyFetcher.java
---
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1577#issuecomment-178683735
Good catch & fix!
+1 to merge asap (too many tests are failing on this one right now)
---
If your project is set up for it, you can reply to this email and have you
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1577#issuecomment-178680229
Good catch! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1577#discussion_r51595056
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/LegacyFetcher.java
---
@@ -199
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1577
[FLINK-3313] [kafka] Fix concurrent TypeInformationSerializationSchema
usage in LegacyFetcher
The LegacyFetcher used the given KeyedDeserializationSchema across multiple
threads even though
11 matches
Mail list logo
