[GitHub] flink pull request: [FLINK-3460] [build] Set Flink dependencies in...

2016-02-21 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/1683 [FLINK-3460] [build] Set Flink dependencies in flink-streaming-connectors to provided The flink-streaming-connectors all depend on flink-streaming-java in compile scope. This entails that

[GitHub] flink pull request: [FLINK-3460] [build] Set Flink dependencies in...

2016-02-22 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1683#issuecomment-187107162 I think we should do the same for other modules such as ml, avro, gelly, gelly-scala, ... --- If your project is set up for it, you can reply to this email and have yo

[GitHub] flink pull request: [FLINK-3460] [build] Set Flink dependencies in...

2016-02-22 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1683#issuecomment-187107667 Thanks for the review @rmetzger. That makes sense. Will update the PR. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-3460] [build] Set Flink dependencies in...

2016-02-22 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1683#issuecomment-187117404 Updated the PR to also set the flink dependencies in flink-batch-connectors, cep, gelly and flink-ml modules to provided. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-3460] [build] Set Flink dependencies in...

2016-02-22 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1683#issuecomment-187125781 I think the change is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] flink pull request: [FLINK-3460] [build] Set Flink dependencies in...

2016-02-23 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1683#issuecomment-187604622 Thanks for the review @rmetzger. Will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] flink pull request: [FLINK-3460] [build] Set Flink dependencies in...

2016-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1683 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab