[GitHub] flink pull request: [FLINK-3482] implement union translation

2016-02-25 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1715 [FLINK-3482] implement union translation This PR add union support to Table on Calcite. I've implemented a custom `JoinUnionTransposeRule` because Calcite's only matches with LogicalUnion. You ca

[GitHub] flink pull request: [FLINK-3482] implement union translation

2016-02-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1715#issuecomment-189208835 Looks good. Can be merged after the comment was added. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-3482] implement union translation

2016-02-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1715#discussion_r54226979 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/logical/FlinkJoinUnionTransposeRule.scala --- @@ -0,0 +1,103 @@

[GitHub] flink pull request: [FLINK-3482] implement union translation

2016-02-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1715#issuecomment-189209810 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] flink pull request: [FLINK-3482] implement union translation

2016-02-26 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1715#issuecomment-189210225 Thanks, I will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink pull request: [FLINK-3482] implement union translation

2016-02-26 Thread vasia
Github user vasia closed the pull request at: https://github.com/apache/flink/pull/1715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl