Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1844
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-206344827
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-206214664
Test fail on Java8 module... Can I merge this @StephanEwen ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1844#discussion_r58665510
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/SpoutSplitExample.java
---
@@ -84,16 +86,27 @@ public static void
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205767304
Done. I needed to restructure class hierarchy, because
`StreamingMultipleProgramsTestBase` did not provided methods for tmp-file
handling...
---
If your project is set
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205744485
For the test, two comments:
- Can you add it to another ITCase (saves bringing an extra mini cluster)
- Also, it will probably not run on windows.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205299917
Change example slightly (make it run finite and added a check for even/odd
stream) and added IT-Case.
---
If your project is set up for it, you can reply to this email
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205286176
IMHO we should have a way to check that examples are working properly. We
don't have to address this in this PR though.
---
If your project is set up for it, you can reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205283761
This is an additional example that runs forever -- it was never designed
for getting tested. Furthermore, there are already two test for split-stream
functionality.
---
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205282397
LGTM. Perhaps we could add a test case for this example?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1844
[FLINK-3523] [Storm-Compatibility] Added SplitStreamMapper to programâ¦
⦠to get rid of SplitStreamType wrapper
You can merge this pull request into a Git repository by running:
$ git pull
11 matches
Mail list logo
