Github user dawidwys closed the pull request at:
https://github.com/apache/flink/pull/1775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1775#issuecomment-196303857
@dawidwys I have merged it. Can you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1775#issuecomment-196299119
@dawidwys I have assigned it to you. Thanks for taking care of this.
Merging this PR now...
---
If your project is set up for it, you can reply to this email and hav
Github user dawidwys commented on the pull request:
https://github.com/apache/flink/pull/1775#issuecomment-196249782
Great. I will gladly take over. Will you assign it to me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1775#issuecomment-196248071
@dawidwys Would you be interested in FLINK-2946? It's currently assigned to
me but I'm working on something else so you can take it if you like.
---
If your project is
Github user dawidwys commented on the pull request:
https://github.com/apache/flink/pull/1775#issuecomment-196227330
@twalthr The Table API operators sounds interesting. I will also gladly
work on the Code generation. Frankly, the least fun would be tests for me.
---
If your project
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1775#issuecomment-196216691
Thanks for implementing my feedback. Looks good to merge. I will merge it
later today if there are no objections.
---
If your project is set up for it, you can reply to
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1775#issuecomment-196215057
@dawidwys do you have any preferences? We have a long list of TODOs not all
of them are represented in Jira issues so far. You can add more tests to verify
Calcite rules
Github user dawidwys commented on the pull request:
https://github.com/apache/flink/pull/1775#issuecomment-195784404
Glad I could help. I would also happily take on another issue regarding
table API and SQL support if you could advise me some.
---
If your project is set up for it, yo
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1775#issuecomment-195776856
Hey @dawidwys, thanks for your contribution!
Your PR looks good besides some small comments. I think we can merge it,
once they are fixed.
---
If your project is se
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1775#discussion_r55924415
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/test/ScalarFunctionsTest.scala
---
@@ -194,6 +195,187 @@ class ScalarFunction
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1775#discussion_r55924167
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/call.scala
---
@@ -61,3 +70,11 @@ object BuiltInFunctionConstants
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1775#discussion_r55924060
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarFunctions.scala
---
@@ -109,13 +110,83 @@ object ScalarFu
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1775#discussion_r55923898
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -70,6 +68,36 @@ trait ImplicitExpressionOper
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1775#discussion_r55497175
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/call.scala
---
@@ -61,3 +70,11 @@ object BuiltInFunctionConstants
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/1775
[FLINK-3574] Implement math functions for Table API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dawidwys/flink mathFunctions
Alternatively
16 matches
Mail list logo
