[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-23 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1831 [FLINK-3659] Allow ConnectedStreams to Be Keyed on Only One Side You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink connected-strea

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-23 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200339097 Thanks Aljoscha, this seems to work :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200888107 For example, how does keyed state work for the input side that is not key partitioned? How is the key found? How is partitioning guaranteed? --- If your project is

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200886203 I think you can go ahead merging this if no-one has any objections :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200887743 Can someone elaborate on the semantics? I am against merging something that changes semantics and has zero description. --- If your project is set up for i

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200907475 @StephanEwen This PR does not change the behaviour of any existing Flink applications. It now allows though that users only specify key of one input of t

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200933436 To elaborate on this. State right now works well if you stick to the (admittedly somewhat hidden) rules. That is, you should only access state if there is a key availab

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200945681 I like @aljoscha's idea to separate more explicitly the user state access and it's implementation. Having an accessor would also allow us to get rid of the swapping

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200951040 Thanks for describing this. This has quite some big implications, as far as I can see it. The state in the connected stream is now a "broadcast state" not pa

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-31 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-203821406 Yes, I'll try and come up with Ideas in that direction then. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-31 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-203821429 Closing this for now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-31 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1831 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en