[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...

2016-05-12 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1973#issuecomment-218780017 @StephanEwen Scala won't let me have overloaded functions. I can only fix it for the Java API because there it is non-breaking. It is, however, a severe limitation for

[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...

2016-05-10 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1973#issuecomment-218145066 I thought it wasn't breaking because it only changes the generic parameters. Any existing user code should still work as before. Or does the generics change break binar

[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...

2016-05-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1973#issuecomment-218142278 This is an API breaking change. Is there a way to overload the functions to make this non-API breaking? --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-3869] Relax window fold generic paramet...

2016-05-09 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1973 [FLINK-3869] Relax window fold generic parameters Before, the WindowFunction in a fold/apply could not emit a type that was different from the accumulator type of the fold. This restriction is