[GitHub] flink pull request: [Flink-1686] Streaming Iterations Slot Sharing...

2015-03-23 Thread senorcarbone
Github user senorcarbone commented on the pull request: https://github.com/apache/flink/pull/524#issuecomment-85223415 bad style habits ^^ thanks for reminding me. I also made a minor fix to the test too. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [Flink-1686] Streaming Iterations Slot Sharing...

2015-03-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/524#discussion_r26966049 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/IterateTest.java --- @@ -87,7 +90,10 @@ public

[GitHub] flink pull request: [Flink-1686] Streaming Iterations Slot Sharing...

2015-03-23 Thread senorcarbone
GitHub user senorcarbone opened a pull request: https://github.com/apache/flink/pull/524 [Flink-1686] Streaming Iterations Slot Sharing Fix Iteration head instances were using the same identifier for slot sharing which resulted into incorrect execution for streaming iterations. I