[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1057#issuecomment-134936395 Ok thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1057#issuecomment-134935236 But you're right, I'll add some documentation to the flink yarn doc, because this is the only place where I see this could be helpful. --- If your project is set up fo

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1057#issuecomment-134934614 Oops, sorry, I merged it already because there weren't any new comments over night. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-26 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1057 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1057#issuecomment-134934294 Could you add some documentation? Looks good to merge otherwise :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-25 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1057#discussion_r37895597 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -127,7 +127,7 @@ FLINK_LIB_DIR=$FLINK_ROOT_DIR/lib # The above lib path is used by the shell scri

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1057#discussion_r37894520 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -127,7 +127,7 @@ FLINK_LIB_DIR=$FLINK_ROOT_DIR/lib # The above lib path is used by the shell

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-25 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1057#issuecomment-134679865 Very useful feature. In addition, I could also imagine that the config file could be passed as a parameter to the ./bin/flink utility. --- If your project is set up for it,

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-25 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1057#discussion_r37894302 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -127,7 +127,7 @@ FLINK_LIB_DIR=$FLINK_ROOT_DIR/lib # The above lib path is used by the shell scri

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-25 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1057 [hotfix] Allow setting FLINK_CONF_DIR by hand This makes it possible for users to set a per-job conf directory when using the one-flink-cluster-per-job mode on yarn. Which enables, for example, per