Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/811
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/811#issuecomment-114153093
Thanks, merging then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/811#issuecomment-114039683
Is there anything blocking this? If not, feel free to go ahead and merge
this. :)
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/811#discussion_r32099679
--- Diff: tools/create_release_files.sh ---
@@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then
exit 1
fi
+##
+## Variable
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/811#discussion_r32098664
--- Diff: tools/create_release_files.sh ---
@@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then
exit 1
fi
+##
+## Variable
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/811#issuecomment-110643230
Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/811#discussion_r32095640
--- Diff: tools/create_release_files.sh ---
@@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then
exit 1
fi
+##
+## Variable
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/811#discussion_r32095648
--- Diff: tools/create_release_files.sh ---
@@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then
exit 1
fi
+##
+## Variable
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/811#issuecomment-110415347
changes look good modulo inline comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/811#discussion_r32029849
--- Diff: tools/create_release_files.sh ---
@@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then
exit 1
fi
+##
+## Variable
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/811#discussion_r32029536
--- Diff: tools/create_release_files.sh ---
@@ -36,57 +58,59 @@ if [[ `basename $CURR_DIR` != "tools" ]] ; then
exit 1
fi
+##
+## Variable
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/811
[scripts] cleanup release script and make it more robust
- fail on command error
- make Mac OS X compatible
- fix uberjar file limit detection
- cleanup
You can merge this pull request into a
12 matches
Mail list logo
