[GitHub] flink pull request: [streaming] Source sync

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [streaming] Source sync

2015-05-28 Thread mbalassi
GitHub user mbalassi opened a pull request: https://github.com/apache/flink/pull/738 [streaming] Source sync This builds on #521 and fixes some issues in it: * The pull request was rebased * fromCollection and generateSequence and the parallel versions have the

[GitHub] flink pull request: [streaming] Source sync

2015-05-28 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/738#issuecomment-106224522 Looks good , but we probably should modify (or add) some tests to test the newly added functions because I think none of the new functionality is tested properly. ---

[GitHub] flink pull request: [streaming] Source sync

2015-05-28 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/738#issuecomment-106225424 Thanks for the review. The test coverage is the following: * The newly introduced `StreamExecutionEnvionmentTest` is for testing the parallelism issues with