Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1972
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1972#issuecomment-219817117
I think this is good, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user scosenza commented on the pull request:
https://github.com/apache/flink/pull/1972#issuecomment-218318387
Hi Robert,
Typically, a test-jar would not contain JUnit test classes unless they are
designed to be extended. On a related note, it's also good to avoid includ
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1972#issuecomment-218087373
Hi,
thank you for opening a pull request about this. I think the change is good
to merge. One thing I'm wondering is: why do you only include on class (or a
set of
Github user scosenza commented on the pull request:
https://github.com/apache/flink/pull/1972#issuecomment-217753936
/cc @jgrier
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user scosenza opened a pull request:
https://github.com/apache/flink/pull/1972
Build a flink-connector-kafka-0.9 test-jar
Build a test-jar of flink-connector-kafka-0.9 so that Flink users can use
KafkaTestEnvironmentImpl to write end to end integration tests of their Flink
j
